Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2153053002: [builtins] Migrate NonNumberToNumber to TurboFan builtin. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Migrate NonNumberToNumber to TurboFan builtin. Migrate the platform NonNumberToNumber builtin to TurboFan, and change it to use the new NonPrimitiveToPrimitive builtin for the JSReceiver case. R=yangguo@chromium.org BUG=v8:5049 Committed: https://crrev.com/ddda77eecaa74b46f9e68f09d70dd4dc5c1b98e0 Cr-Commit-Position: refs/heads/master@{#37786}

Patch Set 1 #

Patch Set 2 : Tail call to StringToNumber #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -274 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/builtins/builtins.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/builtins/builtins.cc View 1 1 chunk +98 lines, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-15 05:54:41 UTC) #1
Yang
lgtm
4 years, 5 months ago (2016-07-15 06:42:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153053002/20001
4 years, 5 months ago (2016-07-15 06:42:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 07:05:32 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 07:06:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddda77eecaa74b46f9e68f09d70dd4dc5c1b98e0
Cr-Commit-Position: refs/heads/master@{#37786}

Powered by Google App Engine
This is Rietveld 408576698