Make "Undo" command to restore selection after validating with the latest Layout tree

Make "Undo" command to restore selection after validating with the latest Layout tree

This patch makes |VisibleSelection::validatePositionsIfNeeded()| to validate
selection if positions of selection are connected to ensure selection is
appropriate for setting to |FrameSelection|.

Before this patch, |validatePositionsIfNeeded()| attempts to validate selection
if positions of selection are connected and one of position has out of bound
offset. This causes we attempt to set selection with dirty layout tree.

This patch also updates expectation of "delete-ligature-003.html" for Mac. All platforms
generate same result after this patch.

BUG=627783
TEST=run_webkit_unit_tests --gtest_filter=VisibleSelectionTest.validatePositionsIfNeededWithShadowHost
TEST=LayoutTests/editing/deleting/delete-ligature-003.html

Committed: https://crrev.com/591157b28b2103a21248e0467a387ad789a37a93
Cr-Commit-Position: refs/heads/master@{#406819}

[yosin_UTC9, 2016-07-15 05:37:11]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 05:37:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 05:39:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 05:39:03]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[yosin_UTC9, 2016-07-15 05:39:58]

Description was changed from

==========
2016-07-15T14:35:50

BUG=
==========

to

==========
editing/deleting/delete-ligature-003.html
editing/pasteboard/data-transfer-items-image-png.html
editing/selection/directionality-after-undo-replace.html
editing/undo/undo-smart-delete-word.html
==========

[yosin_UTC9, 2016-07-15 06:45:40]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 06:45:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 07:48:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 07:48:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-07-15 09:23:04]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 09:23:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 10:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 10:29:33]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-07-20 08:30:38]

Description was changed from

==========
editing/deleting/delete-ligature-003.html
editing/pasteboard/data-transfer-items-image-png.html
editing/selection/directionality-after-undo-replace.html
editing/undo/undo-smart-delete-word.html
==========

to

==========
editing/deleting/delete-ligature-003.html
editing/pasteboard/data-transfer-items-image-png.html
editing/selection/directionality-after-undo-replace.html
editing/undo/undo-smart-delete-word.html


BUG=627783
==========

[yosin_UTC9, 2016-07-21 05:25:04]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 05:25:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 06:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 06:34:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-07-21 07:25:35]

Description was changed from

==========
editing/deleting/delete-ligature-003.html
editing/pasteboard/data-transfer-items-image-png.html
editing/selection/directionality-after-undo-replace.html
editing/undo/undo-smart-delete-word.html


BUG=627783
==========

to

==========
Make "Undo" command to restore selection after validating with the latest Layout
tree

This patch makes |VisibleSelection::validatePositionsIfNeeded()| to validate
selection if positions of selection are connected to ensure selection is
appropriate for setting to |FrameSelection|.

Before this patch, |validatePositionsIfNeeded()| attempts to validate selection
if positions of selection are connected and one of position has out of bound
offset. This causes we attempt to set selection with dirty layout tree.

BUG=627783
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.validatePositionsIfNeededWithShadowHost
==========

[yosin_UTC9, 2016-07-21 07:26:42]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2016-07-21 07:26:43]

PTAL

Once crrev.com/2163163002, which converts delete-ligature-003.html to w3c test
hanress, all tests should be passed.

[yoichio, 2016-07-21 08:21:20]

lgtm

[yosin_UTC9, 2016-07-21 08:29:11]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-07-21 08:29:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-07-21 10:03:22]

Description was changed from

==========
Make "Undo" command to restore selection after validating with the latest Layout
tree

This patch makes |VisibleSelection::validatePositionsIfNeeded()| to validate
selection if positions of selection are connected to ensure selection is
appropriate for setting to |FrameSelection|.

Before this patch, |validatePositionsIfNeeded()| attempts to validate selection
if positions of selection are connected and one of position has out of bound
offset. This causes we attempt to set selection with dirty layout tree.

BUG=627783
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.validatePositionsIfNeededWithShadowHost
==========

to

==========
Make "Undo" command to restore selection after validating with the latest Layout
tree

This patch makes |VisibleSelection::validatePositionsIfNeeded()| to validate
selection if positions of selection are connected to ensure selection is
appropriate for setting to |FrameSelection|.

Before this patch, |validatePositionsIfNeeded()| attempts to validate selection
if positions of selection are connected and one of position has out of bound
offset. This causes we attempt to set selection with dirty layout tree.

This patch also updates expectation of "delete-ligature-003.html" for Mac. All
platforms
generate same result after this patch.

BUG=627783
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.validatePositionsIfNeededWithShadowHost
TEST=LayoutTests/editing/deleting/delete-ligature-003.html
==========

[commit-bot: I haz the power, 2016-07-21 10:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 10:03:59]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-07-21 10:04:45]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-07-21 10:04:45]

The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2153043002/#ps100001
(title: "2016-07-21T19:03:31")

[commit-bot: I haz the power, 2016-07-21 10:04:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 11:45:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-21 11:47:42]

Description was changed from

==========
Make "Undo" command to restore selection after validating with the latest Layout
tree

This patch makes |VisibleSelection::validatePositionsIfNeeded()| to validate
selection if positions of selection are connected to ensure selection is
appropriate for setting to |FrameSelection|.

Before this patch, |validatePositionsIfNeeded()| attempts to validate selection
if positions of selection are connected and one of position has out of bound
offset. This causes we attempt to set selection with dirty layout tree.

This patch also updates expectation of "delete-ligature-003.html" for Mac. All
platforms
generate same result after this patch.

BUG=627783
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.validatePositionsIfNeededWithShadowHost
TEST=LayoutTests/editing/deleting/delete-ligature-003.html
==========

to

==========
Make "Undo" command to restore selection after validating with the latest Layout
tree

This patch makes |VisibleSelection::validatePositionsIfNeeded()| to validate
selection if positions of selection are connected to ensure selection is
appropriate for setting to |FrameSelection|.

Before this patch, |validatePositionsIfNeeded()| attempts to validate selection
if positions of selection are connected and one of position has out of bound
offset. This causes we attempt to set selection with dirty layout tree.

This patch also updates expectation of "delete-ligature-003.html" for Mac. All
platforms
generate same result after this patch.

BUG=627783
TEST=run_webkit_unit_tests
--gtest_filter=VisibleSelectionTest.validatePositionsIfNeededWithShadowHost
TEST=LayoutTests/editing/deleting/delete-ligature-003.html

Committed: https://crrev.com/591157b28b2103a21248e0467a387ad789a37a93
Cr-Commit-Position: refs/heads/master@{#406819}
==========

[commit-bot: I haz the power, 2016-07-21 11:47:43]

Patchset 6 (id:??) landed as
https://crrev.com/591157b28b2103a21248e0467a387ad789a37a93
Cr-Commit-Position: refs/heads/master@{#406819}