chrome/browser/resources/settings/settings_ui/settings_ui.html - Issue 2153013003: MD Settings: Show/hide spinner when searching starts/ends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.html

Issue 2153013003: MD Settings: Show/hide spinner when searching starts/ends. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.js ('k') | chrome/browser/resources/settings/settings_ui/settings_ui.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_ui/settings_ui.html

diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.html b/chrome/browser/resources/settings/settings_ui/settings_ui.html

index ba3b499f56f8693964cbcaf1516bf42f47cddf73..4b5bfebc783dc1730cc62a3676e5587b5df2d8e3 100644

--- a/chrome/browser/resources/settings/settings_ui/settings_ui.html

+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.html

@@ -118,7 +118,8 @@

addressed -->

<cr-toolbar page-name="$i18n{settings}"

clear-label="$i18n{clearSearch}" search-prompt="$i18n{searchPrompt}

- (coming soon!)" on-cr-menu-tap="onMenuButtonTap_">

+ (coming soon!)" on-cr-menu-tap="onMenuButtonTap_"

+ spinner-active="[[toolbarSpinnerActive_]]">

</cr-toolbar>

<app-drawer swipe-open>

<div class="drawer-header">$i18n{settings}</div>

@@ -128,7 +129,8 @@

</div>

</app-drawer>

<paper-header-panel mode="waterfall">

- <settings-main prefs="{{prefs}}" current-route="{{currentRoute}}">

+ <settings-main prefs="{{prefs}}" current-route="{{currentRoute}}"

+ toolbar-spinner-active="{{toolbarSpinnerActive_}}">

</settings-main>

</paper-header-panel>