Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 215293005: Store i18n meta data in hidden symbols instead of js accessible properties (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Store i18n meta data in hidden symbols instead of js accessible properties There were some tests that are supposed to protect against js messing with the meta data, however, they just didn't try hard enough. BUG=354967 R=dcarney@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=20375 Committed: https://code.google.com/p/v8/source/detail?r=20388

Patch Set 1 #

Patch Set 2 : reland #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -233 lines) Patch
M src/heap.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/i18n.js View 23 chunks +30 lines, -36 lines 0 comments Download
M src/runtime.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +81 lines, -0 lines 0 comments Download
D test/intl/break-iterator/protected-icu-internals.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/intl/collator/protected-icu-internals.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/intl/date-format/protected-icu-internals.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/intl/number-format/protected-icu-internals.js View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-03-31 20:53:33 UTC) #1
dcarney
On 2014/03/31 20:53:33, jochen wrote: use private symbols? lgtm
6 years, 8 months ago (2014-04-01 06:51:30 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r20375 (presubmit successful).
6 years, 8 months ago (2014-04-01 07:21:15 UTC) #3
dcarney
lgtm
6 years, 8 months ago (2014-04-01 10:54:19 UTC) #4
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-01 10:56:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20388 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698