Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2152883002: ui: Pass display size by const reference in AddVirtualDisplay (Closed)

Created:
4 years, 5 months ago by robert.bradford
Modified:
4 years, 5 months ago
Reviewers:
*Daniel Erat
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Pass display size by const reference in AddVirtualDisplay BUG=425060 TEST=Build test. Committed: https://crrev.com/bd60f77cb025b9346bb1d39e280faf0e13eef9f8 Cr-Commit-Position: refs/heads/master@{#405568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/display/chromeos/display_configurator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/display_configurator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
robert.bradford
I spotted this whilst I was looking again at extended virtual display support (and how ...
4 years, 5 months ago (2016-07-14 18:36:54 UTC) #5
Daniel Erat
lgtm
4 years, 5 months ago (2016-07-14 19:36:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152883002/1
4 years, 5 months ago (2016-07-14 20:59:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 21:06:20 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:08:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd60f77cb025b9346bb1d39e280faf0e13eef9f8
Cr-Commit-Position: refs/heads/master@{#405568}

Powered by Google App Engine
This is Rietveld 408576698