Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2152853004: [gn] Use PIE in v8 executables (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Use PIE in v8 executables This uses the same compiler flag as the chrome executable does for better performance comparison. BUG=chromium:474921 Committed: https://crrev.com/c6d6cd2fad2d1173bd05c87d088c11324a8264b9 Cr-Commit-Position: refs/heads/master@{#37798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gni/v8.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Achenbach
PTAL - compile v8 executables the same way as the chromium ones are shipped for ...
4 years, 5 months ago (2016-07-15 13:21:22 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-15 14:37:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152853004/1
4 years, 5 months ago (2016-07-15 14:39:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 14:54:05 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 14:56:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6d6cd2fad2d1173bd05c87d088c11324a8264b9
Cr-Commit-Position: refs/heads/master@{#37798}

Powered by Google App Engine
This is Rietveld 408576698