Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

Issue 2152773002: Make scroll anchoring adjustment when the bounds of a scroller is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix failing tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp b/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp
index a290f73e54f6c43887cd90d90600ce301b336ff4..84a7c4024be401ca6710f1845a4ee5d9ae25493d 100644
--- a/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp
+++ b/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp
@@ -194,6 +194,59 @@ TEST_F(ScrollAnchorTest, ClippedScrollersSkipped)
scrollAnchor(viewport).anchorObject());
}
+// Test that scroll anchoring causes no visible jump when a layout change
+// (such as removal of a DOM element) changes the scroll bounds.
+TEST_F(ScrollAnchorTest, AnchoringWhenContentRemoved)
+{
+ setBodyInnerHTML(
+ "<style>"
+ " #changer { height: 1500px; }"
+ " #anchor {"
+ " width: 150px; height: 1000px; background-color: pink;"
+ " }"
+ "</style>"
+ "<div id='changer'></div>"
+ "<div id='anchor'></div>");
+
+ ScrollableArea* viewport = layoutViewport();
+ scrollLayoutViewport(DoubleSize(0, 1600));
+
+ setHeight(document().getElementById("changer"), 0);
+
+ EXPECT_EQ(100, viewport->scrollPosition().y());
+ EXPECT_EQ(document().getElementById("anchor")->layoutObject(),
+ scrollAnchor(viewport).anchorObject());
+}
+
+// Test that scroll anchoring causes no visible jump when a layout change
+// (such as removal of a DOM element) changes the scroll bounds of a scrolling
+// div.
+TEST_F(ScrollAnchorTest, AnchoringWhenContentRemovedFromScrollingDiv)
+{
+ setBodyInnerHTML(
+ "<style>"
+ " #scroller { height: 500px; width: 200px; overflow: scroll; }"
+ " #changer { height: 1500px; }"
+ " #anchor {"
+ " width: 150px; height: 1000px; overflow: scroll;"
+ " }"
+ "</style>"
+ "<div id='scroller'>"
+ " <div id='changer'></div>"
+ " <div id='anchor'></div>"
+ "</div>");
+
+ ScrollableArea* scroller = scrollerForElement(document().getElementById("scroller"));
+
+ document().getElementById("scroller")->setScrollTop(1600);
+
+ setHeight(document().getElementById("changer"), 0);
+
+ EXPECT_EQ(100, scroller->scrollPosition().y());
+ EXPECT_EQ(document().getElementById("anchor")->layoutObject(),
+ scrollAnchor(scroller).anchorObject());
+}
+
TEST_F(ScrollAnchorTest, FractionalOffsetsAreRoundedBeforeComparing)
{
setBodyInnerHTML(
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698