Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2152763002: V8. ASM-2-WASM. Fixes import handling logic. (Closed)

Created:
4 years, 5 months ago by John
Modified:
4 years, 5 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

V8. ASM-2-WASM. Fixes import handling logic. The asm typer would CHECK fail for imports like var bogus = stdlib.<HeapViewType> This CL changes this behavior so the typer reports a validation error instead. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=cctest/asmjs/test-asm-typer.cc LOG=N Committed: https://crrev.com/ca25c845e27fd70952c1333ed877fd0f2e44c37c Cr-Commit-Position: refs/heads/master@{#37777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
John
4 years, 5 months ago (2016-07-14 15:00:12 UTC) #6
bradnelson
lgtm
4 years, 5 months ago (2016-07-14 16:40:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152763002/1
4 years, 5 months ago (2016-07-14 16:40:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 16:43:15 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 16:44:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca25c845e27fd70952c1333ed877fd0f2e44c37c
Cr-Commit-Position: refs/heads/master@{#37777}

Powered by Google App Engine
This is Rietveld 408576698