MD History: Fix forward slash key not working in search field

chrome/browser/resources/md_history/app.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-app',
 
   properties: {
     // The id of the currently selected page.
     selectedPage_: {type: String, value: 'history', observer: 'unselectAll'},
@@ skipping 100 matching lines @@
    * Fired when the user presses 'More from this site'.
    * @param {{detail: {domain: string}}} e
    */
   searchDomain_: function(e) { this.$.toolbar.setSearchTerm(e.detail.domain); },
 
   /**
    * @param {Event} e
    * @private
    */
   onCanExecute_: function(e) {
-    e.canExecute = true;
+    e = /** @type {cr.ui.CanExecuteEvent} */(e);
+    switch (e.command.id) {
+      case 'find-command':
+        e.canExecute = true;
+        break;
+      case 'slash-command':
+        var field =
+            /** @type {CrSearchFieldElement} */ this.$.toolbar.$['main-toolbar']

[Dan Beam, 2016/07/15 05:28:51]

this type should technically be just "SearchField" I believe:
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_search...

[lshang, 2016/07/19 01:23:00]

Or it should be "CrToolbarSearchFieldElement"? though this line is deleted in
the new patch since I directly use this.$.toolbar.searchBar.isSearchFocused()

+                .getSearchField();

[Dan Beam, 2016/07/15 05:28:51]

you should expose this through both HistoryToolbar:

get searchBar() {
  return this.$['main-toolbar'];
},

and CrSearchFieldBehavior, i.e.

isSearchFocused: function() {
  return this.$.searchInput.focused;
},

and do:

e.canExecute = !this.$.toolbar.searchBar.isSearchFocused();

and not poke into local DOM and stuff

[lshang, 2016/07/19 01:23:00]

Done.

+        e.canExecute = !(field.showingSearch && field.focused);
+        break;
+    }
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onCommand_: function(e) {
-    if (e.command.id == 'find-command')
+    if (e.command.id == 'find-command' || e.command.id == 'slash-command')
       this.$.toolbar.showSearchField();
   },
 
   /**
    * @param {!Array<!ForeignSession>} sessionList Array of objects describing
    *     the sessions from other devices.
    * @param {boolean} isTabSyncEnabled Is tab sync enabled for this profile?
    */
   setForeignSessions: function(sessionList, isTabSyncEnabled) {
     if (!isTabSyncEnabled)
@@ skipping 27 matching lines @@
    * @param {boolean} incremental
    * @param {string} searchTerm
    * @return {boolean} Whether a loading spinner should be shown (implies the
    *     backend is querying a new search term).
    * @private
    */
   shouldShowSpinner_: function(querying, incremental, searchTerm) {
     return querying && !incremental && searchTerm != '';
   },
 });