MD History: Fix forward slash key not working in search field

chrome/browser/resources/md_history/app.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 Polymer({
   is: 'history-app',
 
   properties: {
     // The id of the currently selected page.
     selectedPage_: {type: String, value: 'history', observer: 'unselectAll'},
@@ skipping 100 matching lines @@
    * Fired when the user presses 'More from this site'.
    * @param {{detail: {domain: string}}} e
    */
   searchDomain_: function(e) { this.$.toolbar.setSearchTerm(e.detail.domain); },
 
   /**
    * @param {Event} e
    * @private
    */
   onCanExecute_: function(e) {
-    e.canExecute = true;
+    e = /** @type {cr.ui.CanExecuteEvent} */(e);
+    switch (e.command.id) {
+      case 'find-command':
+        e.canExecute = true;
+        break;
+      case 'slash-command':
+        if (this.$.toolbar.showingSearchField())

[Dan Beam, 2016/07/15 03:07:40]

don't you actually want whether the search field is /focused/?

[tsergeant, 2016/07/15 04:06:21]

Yeah, there can be cases where the field is showing but not focused: Click the
field, type in a word, then click outside the field. We'd still want the slash
command to work in those cases.

[lshang, 2016/07/15 05:02:09]

Yep, good point!
I changed to regard forward slash key as normal input when the search field is
both showing and focused.

+          e.canExecute = false;
+        else
+          e.canExecute = true;

[Dan Beam, 2016/07/15 03:07:40]

e.canExecute = !this.$.toolbar.showingSearchField();

[lshang, 2016/07/15 05:02:09]

Done.

+        break;
+    }
   },
 
   /**
    * @param {Event} e
    * @private
    */
   onCommand_: function(e) {
-    if (e.command.id == 'find-command')
+    if (e.command.id == 'find-command' || e.command.id == 'slash-command')
       this.$.toolbar.showSearchField();
   },
 
   /**
    * @param {!Array<!ForeignSession>} sessionList Array of objects describing
    *     the sessions from other devices.
    * @param {boolean} isTabSyncEnabled Is tab sync enabled for this profile?
    */
   setForeignSessions: function(sessionList, isTabSyncEnabled) {
     if (!isTabSyncEnabled)
@@ skipping 27 matching lines @@
    * @param {boolean} incremental
    * @param {string} searchTerm
    * @return {boolean} Whether a loading spinner should be shown (implies the
    *     backend is querying a new search term).
    * @private
    */
   shouldShowSpinner_: function(querying, incremental, searchTerm) {
     return querying && !incremental && searchTerm != '';
   },
 });