Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2152753002: GrBufferAllocPool: use _throw calloc() if unchecked. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GrBufferAllocPool: use _throw calloc() if unchecked. Looks like this code is using sk_calloc(), NULL on failure, accidentally instead of sk_calloc_throw(). We're using sk_malloc_throw() in the parallel code path, so it really seems like we're not checking the result pointer. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152753002 Committed: https://skia.googlesource.com/skia/+/abda35d2b77f2765985ab16d3417c5cce296b8af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrBufferAllocPool.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 5 months ago (2016-07-14 13:40:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152753002/1
4 years, 5 months ago (2016-07-14 13:40:38 UTC) #5
bsalomon
lgtm
4 years, 5 months ago (2016-07-14 13:47:55 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 13:57:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/abda35d2b77f2765985ab16d3417c5cce296b8af

Powered by Google App Engine
This is Rietveld 408576698