Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 2152743003: Update build comment with results of analysis. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update build comment with results of analysis. This is related to a comment about components being source sets on Android. A previous patch speculatively changed a build parameter with a comment referencing the speculative test. Now we know this does affect the runtime but not build performance, so we will keep the change and the comment needs to be updated to reflect this. BUG=619593 Committed: https://crrev.com/322360f3cd7849ab6fd349f34c0f3709a0294b72 Cr-Commit-Position: refs/heads/master@{#405546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
brettw
4 years, 5 months ago (2016-07-14 17:25:24 UTC) #2
brucedawson
lgtm
4 years, 5 months ago (2016-07-14 19:35:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152743003/1
4 years, 5 months ago (2016-07-14 19:37:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 19:42:27 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 19:42:29 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 19:44:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/322360f3cd7849ab6fd349f34c0f3709a0294b72
Cr-Commit-Position: refs/heads/master@{#405546}

Powered by Google App Engine
This is Rietveld 408576698