Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2152733003: gpu_fuzzer: cache shader translators (Closed)

Created:
4 years, 5 months ago by piman
Modified:
4 years, 5 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu_fuzzer: cache shader translators The shader translators are basically stateless, but they get recreated (a costly operation) for every new decoder. Just keeping a reference to them is enough to keep them in the shader translator cache, so introduce a getter for them in the decoder, and keep a reference to them in the fuzzer code. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d9a8b38123edec926b906eff41a6f083ac475c17 Cr-Commit-Position: refs/heads/master@{#406096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.h View 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 2 chunks +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/tests/fuzzer_main.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
piman
4 years, 5 months ago (2016-07-15 01:21:19 UTC) #5
no sievers
lgtm
4 years, 5 months ago (2016-07-18 18:21:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152733003/1
4 years, 5 months ago (2016-07-18 18:59:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 21:12:11 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:12:22 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:14:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9a8b38123edec926b906eff41a6f083ac475c17
Cr-Commit-Position: refs/heads/master@{#406096}

Powered by Google App Engine
This is Rietveld 408576698