tools/metrics/histograms/histograms.xml - Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads

Patch Set: remove histogram checks that can be flaky due to immediate logging Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 190f89cc1e06efe40733069795d383f1a12278e3..33395687f28176a40c297e3be3c59a3445667991 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -37629,6 +37629,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PageLoad.Internal.CommitToComplete.NoTimingIPCs" units="ms">

+ <owner>bmcquade@chromium.org</owner>

+ <summary>

+ The delay between commit and completion, for page loads that did not receive

+ any timing IPCs. This metric is only intended to help understand the cases

+ where committed page loads don't receive timing IPCs. Please contact

+ bmcquade@chromium.org before using this metric.

+ </summary>

+</histogram>

<histogram name="PageLoad.Internal.ProvisionalAbortChainSize.ForwardBack"

units="length">

<owner>csharrison@chromium.org</owner>

« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_observer.cc ('k') | no next file » | no next file with comments »