Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads
Patch Set: remove histogram checks that can be flaky due to immediate logging Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
index 408907f3515d5153df5a35ca7acc9836197af20e..0e92752962753442f83822087d1740a532656016 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
@@ -61,6 +61,9 @@ class FromGWSPageLoadMetricsLogger {
// Invoked when metrics for the given page are complete.
void OnComplete(const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info);
+ void OnFailedProvisionalLoad(
+ const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
+ const page_load_metrics::PageLoadExtraInfo& extra_info);
void OnDomContentLoadedEventStart(
const page_load_metrics::PageLoadTiming& timing,
@@ -87,7 +90,8 @@ class FromGWSPageLoadMetricsLogger {
static bool IsGoogleSearchHostname(base::StringPiece host);
static bool IsGoogleSearchResultUrl(const GURL& url);
static bool IsGoogleSearchRedirectorUrl(const GURL& url);
- bool ShouldLogMetrics(const GURL& url);
+ bool ShouldLogFailedProvisionalLoadMetrics();
+ bool ShouldLogPostCommitMetrics(const GURL& url);
bool ShouldLogForegroundEventAfterCommit(
const base::Optional<base::TimeDelta>& event,
const page_load_metrics::PageLoadExtraInfo& info);
@@ -112,7 +116,6 @@ class FromGWSPageLoadMetricsLogger {
bool previously_committed_url_is_search_redirector_ = false;
bool navigation_initiated_via_link_ = false;
bool provisional_url_has_search_hostname_ = false;
- bool provisional_url_is_non_http_or_https_ = false;
// The state of if first paint is triggered.
bool first_paint_triggered_ = false;
@@ -169,6 +172,9 @@ class FromGWSPageLoadMetricsObserver
void OnComplete(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+ void OnFailedProvisionalLoad(
+ const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
void OnUserInput(const blink::WebInputEvent& event) override;

Powered by Google App Engine
This is Rietveld 408576698