chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h - Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads

Patch Set: remove histogram checks that can be flaky due to immediate logging Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

index 304a25218e53055e2108797ff11c5169bfd5e6b3..01f88a28ba90b319c8e964432dd4e60f7b6ed9c2 100644

--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h

@@ -34,6 +34,9 @@ class AbortsPageLoadMetricsObserver

void OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;

+ void OnFailedProvisionalLoad(

+ const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,

+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;

private:

DISALLOW_COPY_AND_ASSIGN(AbortsPageLoadMetricsObserver);

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc » ('j') | no next file with comments »