components/page_load_metrics/browser/metrics_web_contents_observer.h - Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads

Patch Set: fix metric Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc ('K') | « chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | components/page_load_metrics/browser/page_load_metrics_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.h

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.h b/components/page_load_metrics/browser/metrics_web_contents_observer.h

index 474a4530895f9c39ee22ec7ed8f1fa793f3593d5..f3ecb2a78f2c6292f1b93ad6b174e13ea6c2f634 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.h

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.h

@@ -227,6 +227,8 @@ class PageLoadTracker {

// (before redirects), and the committed url after commit.

GURL url_;

+ base::Optional<FailedProvisionalLoadInfo> failed_provisional_load_info_;

Charlie Harrison 2016/07/18 20:02:18 Can this be a unique_ptr? If we never fail then we

Bryan McQuade 2016/07/19 12:55:38 Good idea, done.

// Will be ABORT_NONE if we have not aborted this load yet. Otherwise will

// be the first abort action the user performed.

UserAbortType abort_type_;