chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc - Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads

Patch Set: fix metric Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h » ('j') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

index e9b54992953749fd657da326def12b5c6183031a..4bb01dd3fda49fb660f42c3027250adc122f34a9 100644

--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

@@ -175,8 +175,6 @@ void DocumentWritePageLoadMetricsObserver::OnLoadingBehaviorObserved(

void DocumentWritePageLoadMetricsObserver::OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) {

- if (!info.time_to_commit || timing.IsEmpty())

Charlie Harrison 2016/07/18 20:02:18 Why remove the IsEmpty() check?

Bryan McQuade 2016/07/19 12:55:38 Yeah, you're right, we might as well return early

- return;

if (info.metadata.behavior_flags &

blink::WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteEvaluator) {

LogDocumentWriteEvaluatorData(timing, info);