Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads
Patch Set: fix metric Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
index ba281a70002fc495677a63447581ffd607fb2865..ad86d75dbf83d92df7c3cf706ace2a3a0c2d92b5 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
@@ -88,25 +88,15 @@ class CorePageLoadMetricsObserver
void OnComplete(const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFailedProvisionalLoad(
- content::NavigationHandle* navigation_handle) override;
+ const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;
private:
- // Information related to failed provisional loads.
- // Populated in OnFailedProvisionalLoad and accessed in OnComplete.
- struct FailedProvisionalLoadInfo {
- base::Optional<base::TimeDelta> interval;
- net::Error error;
-
- FailedProvisionalLoadInfo();
- ~FailedProvisionalLoadInfo();
- };
-
void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info);
void RecordRappor(const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info);
- FailedProvisionalLoadInfo failed_provisional_load_info_;
ui::PageTransition transition_;
bool initiated_by_user_gesture_;

Powered by Google App Engine
This is Rietveld 408576698