Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: components/page_load_metrics/browser/page_load_metrics_observer.cc

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads
Patch Set: remove histogram checks that can be flaky due to immediate logging Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 5 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
6 6
7 namespace page_load_metrics { 7 namespace page_load_metrics {
8 8
9 PageLoadExtraInfo::PageLoadExtraInfo( 9 PageLoadExtraInfo::PageLoadExtraInfo(
10 const base::Optional<base::TimeDelta>& first_background_time, 10 const base::Optional<base::TimeDelta>& first_background_time,
11 const base::Optional<base::TimeDelta>& first_foreground_time, 11 const base::Optional<base::TimeDelta>& first_foreground_time,
12 bool started_in_foreground, 12 bool started_in_foreground,
13 const GURL& committed_url, 13 const GURL& committed_url,
14 const base::Optional<base::TimeDelta>& time_to_commit, 14 const base::Optional<base::TimeDelta>& time_to_commit,
15 UserAbortType abort_type, 15 UserAbortType abort_type,
16 const base::Optional<base::TimeDelta>& time_to_abort, 16 const base::Optional<base::TimeDelta>& time_to_abort,
17 const PageLoadMetadata& metadata) 17 const PageLoadMetadata& metadata)
18 : first_background_time(first_background_time), 18 : first_background_time(first_background_time),
19 first_foreground_time(first_foreground_time), 19 first_foreground_time(first_foreground_time),
20 started_in_foreground(started_in_foreground), 20 started_in_foreground(started_in_foreground),
21 committed_url(committed_url), 21 committed_url(committed_url),
22 time_to_commit(time_to_commit), 22 time_to_commit(time_to_commit),
23 abort_type(abort_type), 23 abort_type(abort_type),
24 time_to_abort(time_to_abort), 24 time_to_abort(time_to_abort),
25 metadata(metadata) {} 25 metadata(metadata) {}
26 26
27 PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default; 27 PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default;
28 28
29 PageLoadExtraInfo::~PageLoadExtraInfo() {} 29 PageLoadExtraInfo::~PageLoadExtraInfo() {}
30
31 FailedProvisionalLoadInfo::FailedProvisionalLoadInfo(base::TimeDelta interval,
32 net::Error error)
33 : time_to_failed_provisional_load(interval), error(error) {}
34
35 FailedProvisionalLoadInfo::~FailedProvisionalLoadInfo() {}
36
30 } // namespace page_load_metrics 37 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698