Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads
Patch Set: remove histogram checks that can be flaky due to immediate logging Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <vector> 10 #include <vector>
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 const base::TimeTicks navigation_start_; 220 const base::TimeTicks navigation_start_;
221 221
222 // Time this page load was committed. If this page load hasn't committed, 222 // Time this page load was committed. If this page load hasn't committed,
223 // |commit_time_| will be zero. 223 // |commit_time_| will be zero.
224 base::TimeTicks commit_time_; 224 base::TimeTicks commit_time_;
225 225
226 // The URL of this page load. This is the provisional url before commit 226 // The URL of this page load. This is the provisional url before commit
227 // (before redirects), and the committed url after commit. 227 // (before redirects), and the committed url after commit.
228 GURL url_; 228 GURL url_;
229 229
230 std::unique_ptr<FailedProvisionalLoadInfo> failed_provisional_load_info_;
231
230 // Will be ABORT_NONE if we have not aborted this load yet. Otherwise will 232 // Will be ABORT_NONE if we have not aborted this load yet. Otherwise will
231 // be the first abort action the user performed. 233 // be the first abort action the user performed.
232 UserAbortType abort_type_; 234 UserAbortType abort_type_;
233 base::TimeTicks abort_time_; 235 base::TimeTicks abort_time_;
234 236
235 // We record separate metrics for events that occur after a background, 237 // We record separate metrics for events that occur after a background,
236 // because metrics like layout/paint are delayed artificially 238 // because metrics like layout/paint are delayed artificially
237 // when they occur in the background. 239 // when they occur in the background.
238 base::TimeTicks background_time_; 240 base::TimeTicks background_time_;
239 base::TimeTicks foreground_time_; 241 base::TimeTicks foreground_time_;
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 362
361 // Has the MWCO observed at least one navigation? 363 // Has the MWCO observed at least one navigation?
362 bool has_navigated_; 364 bool has_navigated_;
363 365
364 DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver); 366 DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);
365 }; 367 };
366 368
367 } // namespace page_load_metrics 369 } // namespace page_load_metrics
368 370
369 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_ 371 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698