Refactor PageLoadMetricsObserver completion callback policy

chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
 
 #include "base/macros.h"
 #include "base/optional.h"
 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
@@ skipping 43 matching lines @@
 
   void SetNavigationStart(const base::TimeTicks navigation_start) {
     // Should be invoked at most once
     DCHECK(navigation_start_.is_null());
     navigation_start_ = navigation_start;
   }
 
   // Invoked when metrics for the given page are complete.
   void OnComplete(const page_load_metrics::PageLoadTiming& timing,
                   const page_load_metrics::PageLoadExtraInfo& extra_info);
+  void OnFailedProvisionalLoad(
+      const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
+      const page_load_metrics::PageLoadExtraInfo& extra_info);
 
   void OnDomContentLoadedEventStart(
       const page_load_metrics::PageLoadTiming& timing,
       const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnLoadEventStart(const page_load_metrics::PageLoadTiming& timing,
                         const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnFirstPaint(const page_load_metrics::PageLoadTiming& timing,
                     const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnFirstTextPaint(const page_load_metrics::PageLoadTiming& timing,
                         const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnFirstImagePaint(
       const page_load_metrics::PageLoadTiming& timing,
       const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnFirstContentfulPaint(
       const page_load_metrics::PageLoadTiming& timing,
       const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnParseStart(const page_load_metrics::PageLoadTiming& timing,
                     const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnParseStop(const page_load_metrics::PageLoadTiming& timing,
                    const page_load_metrics::PageLoadExtraInfo& extra_info);
   void OnUserInput(const blink::WebInputEvent& event);
 
   // The methods below are public only for testing.
   static bool IsGoogleSearchHostname(base::StringPiece host);
   static bool IsGoogleSearchResultUrl(const GURL& url);
   static bool IsGoogleSearchRedirectorUrl(const GURL& url);
-  bool ShouldLogMetrics(const GURL& url);
+  bool ShouldLogFailedProvisionalLoadMetrics();
+  bool ShouldLogPostCommitMetrics(const GURL& url);
   bool ShouldLogForegroundEventAfterCommit(
       const base::Optional<base::TimeDelta>& event,
       const page_load_metrics::PageLoadExtraInfo& info);
 
   // Whether the given query string contains the given component. The query
   // parameter should contain the query string of a URL (the portion following
   // the question mark, excluding the question mark). The component must fully
   // match a component in the query string. For example, 'foo=bar' would match
   // the query string 'a=b&foo=bar&c=d' but would not match 'a=b&zzzfoo=bar&c=d'
   // since, though foo=bar appears in the query string, the key specified in the
   // component 'foo' does not match the full key in the query string
   // 'zzzfoo'. For QueryContainsComponent, the component should of the form
   // 'key=value'. For QueryContainsComponentPrefix, the component should be of
   // the form 'key=' (where the value is not specified).
   static bool QueryContainsComponent(const base::StringPiece query,
                                      const base::StringPiece component);
   static bool QueryContainsComponentPrefix(const base::StringPiece query,
                                            const base::StringPiece component);
 
  private:
   bool previously_committed_url_is_search_results_ = false;
   bool previously_committed_url_is_search_redirector_ = false;
   bool navigation_initiated_via_link_ = false;
   bool provisional_url_has_search_hostname_ = false;
-  bool provisional_url_is_non_http_or_https_ = false;
 
   // The state of if first paint is triggered.
   bool first_paint_triggered_ = false;
 
   base::TimeTicks navigation_start_;
 
   // The time of first user interaction after paint from navigation start.
   base::Optional<base::TimeDelta> first_user_interaction_after_paint_;
 
   // Common helper for QueryContainsComponent and QueryContainsComponentPrefix.
@@ skipping 36 matching lines @@
   void OnParseStart(
       const page_load_metrics::PageLoadTiming& timing,
       const page_load_metrics::PageLoadExtraInfo& extra_info) override;
   void OnParseStop(
       const page_load_metrics::PageLoadTiming& timing,
       const page_load_metrics::PageLoadExtraInfo& extra_info) override;
 
   void OnComplete(
       const page_load_metrics::PageLoadTiming& timing,
       const page_load_metrics::PageLoadExtraInfo& extra_info) override;
+  void OnFailedProvisionalLoad(
+      const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
+      const page_load_metrics::PageLoadExtraInfo& extra_info) override;
 
   void OnUserInput(const blink::WebInputEvent& event) override;
 
  private:
   FromGWSPageLoadMetricsLogger logger_;
 
   DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver);
 };
 
 #endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_