Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2152683004: Refactor PageLoadMetricsObserver completion callback policy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@relevantloads
Patch Set: fix metric Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_
7 7
8 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 8 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
9 9
10 namespace internal { 10 namespace internal {
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 81 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
82 void OnParseStart( 82 void OnParseStart(
83 const page_load_metrics::PageLoadTiming& timing, 83 const page_load_metrics::PageLoadTiming& timing,
84 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 84 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
85 void OnParseStop( 85 void OnParseStop(
86 const page_load_metrics::PageLoadTiming& timing, 86 const page_load_metrics::PageLoadTiming& timing,
87 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 87 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
88 void OnComplete(const page_load_metrics::PageLoadTiming& timing, 88 void OnComplete(const page_load_metrics::PageLoadTiming& timing,
89 const page_load_metrics::PageLoadExtraInfo& info) override; 89 const page_load_metrics::PageLoadExtraInfo& info) override;
90 void OnFailedProvisionalLoad( 90 void OnFailedProvisionalLoad(
91 content::NavigationHandle* navigation_handle) override; 91 const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
92 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
92 93
93 private: 94 private:
94 // Information related to failed provisional loads.
95 // Populated in OnFailedProvisionalLoad and accessed in OnComplete.
96 struct FailedProvisionalLoadInfo {
97 base::Optional<base::TimeDelta> interval;
98 net::Error error;
99
100 FailedProvisionalLoadInfo();
101 ~FailedProvisionalLoadInfo();
102 };
103
104 void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing, 95 void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,
105 const page_load_metrics::PageLoadExtraInfo& info); 96 const page_load_metrics::PageLoadExtraInfo& info);
106 void RecordRappor(const page_load_metrics::PageLoadTiming& timing, 97 void RecordRappor(const page_load_metrics::PageLoadTiming& timing,
107 const page_load_metrics::PageLoadExtraInfo& info); 98 const page_load_metrics::PageLoadExtraInfo& info);
108 99
109 FailedProvisionalLoadInfo failed_provisional_load_info_;
110 ui::PageTransition transition_; 100 ui::PageTransition transition_;
111 bool initiated_by_user_gesture_; 101 bool initiated_by_user_gesture_;
112 102
113 DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver); 103 DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver);
114 }; 104 };
115 105
116 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBS ERVER_H_ 106 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBS ERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698