third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py - Issue 2152663003: Refactor the buildbot module in webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

Issue 2152663003: Refactor the buildbot module in webkitpy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

index d8617bb75d0a1d182c0f4749e4ec234b664e69d2..313c4ce97988436c627a8cc8e62ea5c576d7cb4c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py

@@ -104,9 +104,9 @@ class RebaselineFromTryJobs(AbstractParallelRebaselineCommand):

def _unexpected_mismatch_results(self, try_job):

"""Fetches a list of LayoutTestResult objects for unexpected results with new baselines."""

- results_url = self._results_url(try_job.builder_name, try_job.build_number)

- builder = self._tool.buildbot.builder_with_name(try_job.builder_name)

- layout_test_results = builder.fetch_layout_test_results(results_url)

+ buildbot = self._tool.buildbot

+ results_url = buildbot.results_url(try_job.builder_name, try_job.build_number)

+ layout_test_results = buildbot.fetch_layout_test_results(results_url)

if layout_test_results is None:

_log.warning('Failed to request layout test results from "%s".', results_url)

return []