Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2152643002: SELECT element: Introduce HTMLSelectElement::optionAtListIndex(). (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Introduce HTMLSelectElement::optionAtListIndex(). It simplifies some code. This CL has no behavior changes. Committed: https://crrev.com/93437e07f5a150f8ea3511c8543ec6571dd5be14 Cr-Commit-Position: refs/heads/master@{#405439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 8 chunks +26 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-07-14 02:21:40 UTC) #4
keishi
LGTM
4 years, 5 months ago (2016-07-14 04:09:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152643002/1
4 years, 5 months ago (2016-07-14 04:33:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 06:06:07 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 06:08:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93437e07f5a150f8ea3511c8543ec6571dd5be14
Cr-Commit-Position: refs/heads/master@{#405439}

Powered by Google App Engine
This is Rietveld 408576698