Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 215253002: Roll libvpx 259324:259953. (Closed)

Created:
6 years, 9 months ago by earthdok
Modified:
6 years, 9 months ago
Reviewers:
Tom Finegan
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : refresh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
Committed patchset #3 manually as r260018 (presubmit successful).
6 years, 9 months ago (2014-03-27 22:40:31 UTC) #1
Tom Finegan
On 2014/03/27 22:40:31, earthdok wrote: > Committed patchset #3 manually as r260018 (presubmit successful). lgtm ...
6 years, 9 months ago (2014-03-27 22:53:05 UTC) #2
earthdok
On 2014/03/27 22:53:05, Tom Finegan wrote: > On 2014/03/27 22:40:31, earthdok wrote: > > Committed ...
6 years, 9 months ago (2014-03-27 23:01:52 UTC) #3
Tom Finegan
6 years, 9 months ago (2014-03-27 23:04:32 UTC) #4
Message was sent while issue was closed.
On 2014/03/27 23:01:52, earthdok wrote:
> On 2014/03/27 22:53:05, Tom Finegan wrote:
> > On 2014/03/27 22:40:31, earthdok wrote:
> > > Committed patchset #3 manually as r260018 (presubmit successful).
> > 
> > lgtm [rubber stamp]
> > 
> > It's pretty incredibly brave to land this without the CQ, based on past
> > experience. Hopefully things work out...
> 
> I did a "git cl try -t remoting_unittests" in patch set 2. Should be enough
for
> this kind of change I think, even just compile would probably have sufficed.

No worries: libvpx has very rough rolls from time to time. I wasn't implying any
irresponsibility on your part-- more trying to convey my surprise at seeing that
this had already landed. :)

Powered by Google App Engine
This is Rietveld 408576698