Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2152523002: Exclude some WebUI resources from analysis until GN considers data files (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude some WebUI resources from analysis until GN considers data files R=dpranke@chromium.org BUG=628783 Committed: https://crrev.com/385bdb40ca9b717653a3a32064afa67df50d5e97 Cr-Commit-Position: refs/heads/master@{#405905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M testing/buildbot/trybot_analyze_config.json View 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Beam
4 years, 5 months ago (2016-07-15 22:22:21 UTC) #3
Dirk Pranke
lgtm.
4 years, 5 months ago (2016-07-15 22:28:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152523002/1
4 years, 5 months ago (2016-07-15 22:36:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-16 00:04:10 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 00:09:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/385bdb40ca9b717653a3a32064afa67df50d5e97
Cr-Commit-Position: refs/heads/master@{#405905}

Powered by Google App Engine
This is Rietveld 408576698