Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2152493002: Revert of Forward password-store switch to OSCrypt component (Closed)

Created:
4 years, 5 months ago by cfroussios
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, engedy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Forward password-store switch to OSCrypt component (patchset #15 id:310001 of https://codereview.chromium.org/2118443002/ ) Reason for revert: mahmadi@ reported reaching the DCHECK in components/os_crypt/os_crypt_linux.cc Original issue's description: > Forward password-store switch to OSCrypt component > > Password manager uses a switch to allow the user to override the > auto-detection of the appropriate password store. OSCrypt should > respect this switch as well. > > The switch value is read and passed to OSCrypt at a very early > point in Chrome's start, before any of OSCrypt's dependents > use it. > > I also reworked OSCrypt's build to make it simpler for chrome to > deduce whether the linux implementation of OSCrypt will be used. > - Previously, os_crypt_linux was used only if we also decided to > link at least one linux backend. Otherwise we used os_crypt_posix. > + Now, we always use the linux implementation for linux. If no > KeyStorage is linked, the linux implementation defaults to the > same behavior as for posix. > > BUG=602624 > > Committed: https://crrev.com/92699e345c15243c4023a8739101333ed2658e37 > Cr-Commit-Position: refs/heads/master@{#405114} TBR=thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602624 Committed: https://crrev.com/7e8f3ac9fc9e4a8588e900b7fce5492c26da1986 Cr-Commit-Position: refs/heads/master@{#405197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -86 lines) Patch
M chrome/browser/chrome_browser_main_linux.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/os_crypt.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M components/os_crypt/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M components/os_crypt/key_storage_linux.h View 1 chunk +2 lines, -4 lines 0 comments Download
M components/os_crypt/key_storage_linux.cc View 1 chunk +3 lines, -45 lines 0 comments Download
M components/os_crypt/os_crypt.h View 4 chunks +5 lines, -11 lines 0 comments Download
M components/os_crypt/os_crypt_linux.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
cfroussios
Created Revert of Forward password-store switch to OSCrypt component
4 years, 5 months ago (2016-07-13 16:53:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152493002/1
4 years, 5 months ago (2016-07-13 16:54:22 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-13 16:54:23 UTC) #5
engedy
Rubberstamp LGTM.
4 years, 5 months ago (2016-07-13 16:56:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2152493002/1
4 years, 5 months ago (2016-07-13 16:57:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 16:58:39 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:59:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e8f3ac9fc9e4a8588e900b7fce5492c26da1986
Cr-Commit-Position: refs/heads/master@{#405197}

Powered by Google App Engine
This is Rietveld 408576698