DescriptionRevert of Forward password-store switch to OSCrypt component (patchset #15 id:310001 of https://codereview.chromium.org/2118443002/ )
Reason for revert:
mahmadi@ reported reaching the DCHECK in components/os_crypt/os_crypt_linux.cc
Original issue's description:
> Forward password-store switch to OSCrypt component
>
> Password manager uses a switch to allow the user to override the
> auto-detection of the appropriate password store. OSCrypt should
> respect this switch as well.
>
> The switch value is read and passed to OSCrypt at a very early
> point in Chrome's start, before any of OSCrypt's dependents
> use it.
>
> I also reworked OSCrypt's build to make it simpler for chrome to
> deduce whether the linux implementation of OSCrypt will be used.
> - Previously, os_crypt_linux was used only if we also decided to
> link at least one linux backend. Otherwise we used os_crypt_posix.
> + Now, we always use the linux implementation for linux. If no
> KeyStorage is linked, the linux implementation defaults to the
> same behavior as for posix.
>
> BUG=602624
>
> Committed: https://crrev.com/92699e345c15243c4023a8739101333ed2658e37
> Cr-Commit-Position: refs/heads/master@{#405114}
TBR=thestig@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602624
Committed: https://crrev.com/7e8f3ac9fc9e4a8588e900b7fce5492c26da1986
Cr-Commit-Position: refs/heads/master@{#405197}
Patch Set 1 #
Messages
Total messages: 12 (5 generated)
|