scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json

index dff9d143864fb74195a61e6bc576aa43590c4efa..59fc2a1c25392a543afd0fb0ae6cd8d62a7b7590 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___builder.json

@@ -291,8 +291,6 @@

"[SLAVE_BUILD]\\v8",

"--goma-cache-dir",

"[GOMA_CACHE]",

- "--build-tool",

- "ninja",

"--compiler",

"goma",

"--goma-jsonstatus",