scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_mac_mac_chromium_gn_upload.json ('k') | scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

diff --git a/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json b/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

index 6622d9e673372fb6312e0f083a4e607b31fb1e47..2a2f7526dd3caf4c359c4794d3b5ba3acbb6ae22 100644

--- a/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

+++ b/scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json

@@ -184,8 +184,6 @@

"[SLAVE_BUILD]\\src",

"--goma-cache-dir",

"[GOMA_CACHE]",

- "--build-tool",

- "ninja",

"--compiler",

"goma",

"--goma-jsonstatus",