scripts/slave/recipe_modules/chromium/api.py - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index 9a3cdfbd90ef4bd685ea27b812f37195a398852c..6ab055aaae4aad6bf9b2340975807fc5e70ab477 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -185,8 +185,6 @@ class ChromiumApi(recipe_api.RecipeApi):

if self.c.compile_py.build_args:

args += ['--build-args', self.c.compile_py.build_args]

- # TODO(thakis): Stop passing --build-tool, there is just one.

- args += ['--build-tool', 'ninja']

if self.m.properties.get('build_data_dir'):

args += ['--build-data-dir', self.m.properties.get('build_data_dir')]

if self.c.compile_py.compiler:

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »