scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_dbg.json ('k') | scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_compile_dbg.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "name": "taskkill"	8 "name": "taskkill"

9 },	9 },

10 {	10 {

(...skipping 279 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
290 "--gsutil-py-path",	290 "--gsutil-py-path",

291 "RECIPE_PACKAGE_REPO[depot_tools]\\gsutil.py",	291 "RECIPE_PACKAGE_REPO[depot_tools]\\gsutil.py",

292 "--ninja-path",	292 "--ninja-path",

293 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",	293 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",

294 "--target",	294 "--target",

295 "Release_x64",	295 "Release_x64",

296 "--src-dir",	296 "--src-dir",

297 "[SLAVE_BUILD]\\v8",	297 "[SLAVE_BUILD]\\v8",

298 "--goma-cache-dir",	298 "--goma-cache-dir",

299 "[GOMA_CACHE]",	299 "[GOMA_CACHE]",

300 "--build-tool",

301 "ninja",

302 "--compiler",	300 "--compiler",

303 "goma",	301 "goma",

304 "--goma-jsonstatus",	302 "--goma-jsonstatus",

305 "/path/to/tmp/json",	303 "/path/to/tmp/json",

306 "--goma-service-account-json-file",	304 "--goma-service-account-json-file",

307 "C:\\creds\\service_accounts\\service-account-goma-client.json",	305 "C:\\creds\\service_accounts\\service-account-goma-client.json",

308 "--goma-dir",	306 "--goma-dir",

309 "[CACHE]\\cipd\\goma",	307 "[CACHE]\\cipd\\goma",

310 "--goma-fail-fast",	308 "--goma-fail-fast",

311 "--goma-disable-local-fallback",	309 "--goma-disable-local-fallback",

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
380 "~followup_annotations": [	378 "~followup_annotations": [

381 "@@@STEP_TEXT@v8_win64_rel_ng_triggered@@@"	379 "@@@STEP_TEXT@v8_win64_rel_ng_triggered@@@"

382 ]	380 ]

383 },	381 },

384 {	382 {

385 "name": "$result",	383 "name": "$result",

386 "recipe_result": null,	384 "recipe_result": null,

387 "status_code": 0	385 "status_code": 0

388 }	386 }

389 ]	387 ]

OLD	NEW