scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___nosnap___shared.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___clang.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "name": "taskkill"	8 "name": "taskkill"

9 },	9 },

10 {	10 {

(...skipping 273 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
284 "--gsutil-py-path",	284 "--gsutil-py-path",

285 "RECIPE_PACKAGE_REPO[depot_tools]\\gsutil.py",	285 "RECIPE_PACKAGE_REPO[depot_tools]\\gsutil.py",

286 "--ninja-path",	286 "--ninja-path",

287 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",	287 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",

288 "--target",	288 "--target",

289 "Release_x64",	289 "Release_x64",

290 "--src-dir",	290 "--src-dir",

291 "[SLAVE_BUILD]\\v8",	291 "[SLAVE_BUILD]\\v8",

292 "--goma-cache-dir",	292 "--goma-cache-dir",

293 "[GOMA_CACHE]",	293 "[GOMA_CACHE]",

294 "--build-tool",

295 "ninja",

296 "--compiler",	294 "--compiler",

297 "goma",	295 "goma",

298 "--goma-jsonstatus",	296 "--goma-jsonstatus",

299 "/path/to/tmp/json",	297 "/path/to/tmp/json",

300 "--goma-service-account-json-file",	298 "--goma-service-account-json-file",

301 "C:\\creds\\service_accounts\\service-account-goma-client.json",	299 "C:\\creds\\service_accounts\\service-account-goma-client.json",

302 "--goma-dir",	300 "--goma-dir",

303 "[CACHE]\\cipd\\goma",	301 "[CACHE]\\cipd\\goma",

304 "--"	302 "--"

305 ],	303 ],

(...skipping 708 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1014 "@@@STEP_LOG_LINE@durations@Duration: 00:00:101@@@",	1012 "@@@STEP_LOG_LINE@durations@Duration: 00:00:101@@@",

1015 "@@@STEP_LOG_END@durations@@@"	1013 "@@@STEP_LOG_END@durations@@@"

1016 ]	1014 ]

1017 },	1015 },

1018 {	1016 {

1019 "name": "$result",	1017 "name": "$result",

1020 "recipe_result": null,	1018 "recipe_result": null,

1021 "status_code": 0	1019 "status_code": 0

1022 }	1020 }

1023 ]	1021 ]

OLD	NEW