scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___xcode.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___xcode.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac_GC_Stress.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "client.v8",	8 "client.v8",

9 "--builder",	9 "--builder",

10 "V8 Mac64 - xcode",	10 "V8 Mac64 - xcode",

(...skipping 233 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
244 "--gsutil-py-path",	244 "--gsutil-py-path",

245 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	245 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

246 "--ninja-path",	246 "--ninja-path",

247 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	247 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

248 "--target",	248 "--target",

249 "Release",	249 "Release",

250 "--src-dir",	250 "--src-dir",

251 "[SLAVE_BUILD]/v8",	251 "[SLAVE_BUILD]/v8",

252 "--goma-cache-dir",	252 "--goma-cache-dir",

253 "[GOMA_CACHE]",	253 "[GOMA_CACHE]",

254 "--build-tool",

255 "ninja",

256 "--compiler",	254 "--compiler",

257 "goma-clang",	255 "goma-clang",

258 "--goma-jsonstatus",	256 "--goma-jsonstatus",

259 "/path/to/tmp/json",	257 "/path/to/tmp/json",

260 "--goma-service-account-json-file",	258 "--goma-service-account-json-file",

261 "/creds/service_accounts/service-account-goma-client.json",	259 "/creds/service_accounts/service-account-goma-client.json",

262 "--goma-dir",	260 "--goma-dir",

263 "[CACHE]/cipd/goma",	261 "[CACHE]/cipd/goma",

264 "--"	262 "--"

265 ],	263 ],

266 "env": {	264 "env": {

267 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"	265 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

268 },	266 },

269 "name": "compile",	267 "name": "compile",

270 "~followup_annotations": [	268 "~followup_annotations": [

271 "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",	269 "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",

272 "@@@STEP_LOG_END@json.output (invalid)@@@"	270 "@@@STEP_LOG_END@json.output (invalid)@@@"

273 ]	271 ]

274 },	272 },

275 {	273 {

276 "name": "$result",	274 "name": "$result",

277 "recipe_result": null,	275 "recipe_result": null,

278 "status_code": 0	276 "status_code": 0

279 }	277 }

280 ]	278 ]

OLD	NEW