scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_gcc_4_8.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "client.v8",	8 "client.v8",

9 "--builder",	9 "--builder",

10 "V8 Mac",	10 "V8 Mac",

(...skipping 284 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
295 "--gsutil-py-path",	295 "--gsutil-py-path",

296 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	296 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

297 "--ninja-path",	297 "--ninja-path",

298 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	298 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

299 "--target",	299 "--target",

300 "Release",	300 "Release",

301 "--src-dir",	301 "--src-dir",

302 "[SLAVE_BUILD]/v8",	302 "[SLAVE_BUILD]/v8",

303 "--goma-cache-dir",	303 "--goma-cache-dir",

304 "[GOMA_CACHE]",	304 "[GOMA_CACHE]",

305 "--build-tool",

306 "ninja",

307 "--compiler",	305 "--compiler",

308 "goma-clang",	306 "goma-clang",

309 "--goma-jsonstatus",	307 "--goma-jsonstatus",

310 "/path/to/tmp/json",	308 "/path/to/tmp/json",

311 "--goma-service-account-json-file",	309 "--goma-service-account-json-file",

312 "/creds/service_accounts/service-account-goma-client.json",	310 "/creds/service_accounts/service-account-goma-client.json",

313 "--goma-dir",	311 "--goma-dir",

314 "[CACHE]/cipd/goma",	312 "[CACHE]/cipd/goma",

315 "--"	313 "--"

316 ],	314 ],

(...skipping 708 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1025 "@@@STEP_LOG_LINE@durations@Duration: 00:00:101@@@",	1023 "@@@STEP_LOG_LINE@durations@Duration: 00:00:101@@@",

1026 "@@@STEP_LOG_END@durations@@@"	1024 "@@@STEP_LOG_END@durations@@@"

1027 ]	1025 ]

1028 },	1026 },

1029 {	1027 {

1030 "name": "$result",	1028 "name": "$result",

1031 "recipe_result": null,	1029 "recipe_result": null,

1032 "status_code": 0	1030 "status_code": 0

1033 }	1031 }

1034 ]	1032 ]

OLD	NEW