scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "client.v8",	8 "client.v8",

9 "--builder",	9 "--builder",

10 "V8 Linux64 - cfi",	10 "V8 Linux64 - cfi",

(...skipping 262 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
273 "--gsutil-py-path",	273 "--gsutil-py-path",

274 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	274 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

275 "--ninja-path",	275 "--ninja-path",

276 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	276 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

277 "--target",	277 "--target",

278 "Release",	278 "Release",

279 "--src-dir",	279 "--src-dir",

280 "[SLAVE_BUILD]/v8",	280 "[SLAVE_BUILD]/v8",

281 "--goma-cache-dir",	281 "--goma-cache-dir",

282 "[GOMA_CACHE]",	282 "[GOMA_CACHE]",

283 "--build-tool",

284 "ninja",

285 "--compiler",	283 "--compiler",

286 "goma",	284 "goma",

287 "--goma-jsonstatus",	285 "--goma-jsonstatus",

288 "/path/to/tmp/json",	286 "/path/to/tmp/json",

289 "--goma-service-account-json-file",	287 "--goma-service-account-json-file",

290 "/creds/service_accounts/service-account-goma-client.json",	288 "/creds/service_accounts/service-account-goma-client.json",

291 "--goma-dir",	289 "--goma-dir",

292 "[CACHE]/cipd/goma",	290 "[CACHE]/cipd/goma",

293 "--"	291 "--"

294 ],	292 ],

(...skipping 989 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1284 "@@@STEP_LOG_LINE@durations@Duration: 00:00:101@@@",	1282 "@@@STEP_LOG_LINE@durations@Duration: 00:00:101@@@",

1285 "@@@STEP_LOG_END@durations@@@"	1283 "@@@STEP_LOG_END@durations@@@"

1286 ]	1284 ]

1287 },	1285 },

1288 {	1286 {

1289 "name": "$result",	1287 "name": "$result",

1290 "recipe_result": null,	1288 "recipe_result": null,

1291 "status_code": 0	1289 "status_code": 0

1292 }	1290 }

1293 ]	1291 ]

OLD	NEW