scripts/slave/recipes/nacl/sdk.expected/basic.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/nacl/sdk.expected/basic.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_win_x64_rel.json ('k') | scripts/slave/recipes/ozone_ecs.expected/basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.testing.master",	8 "chromium.testing.master",

9 "--builder",	9 "--builder",

10 "TestBuilder",	10 "TestBuilder",

(...skipping 152 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
163 "--gsutil-py-path",	163 "--gsutil-py-path",

164 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	164 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

165 "--ninja-path",	165 "--ninja-path",

166 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	166 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

167 "--target",	167 "--target",

168 "Release",	168 "Release",

169 "--src-dir",	169 "--src-dir",

170 "[SLAVE_BUILD]/src",	170 "[SLAVE_BUILD]/src",

171 "--goma-cache-dir",	171 "--goma-cache-dir",

172 "[GOMA_CACHE]",	172 "[GOMA_CACHE]",

173 "--build-tool",

174 "ninja",

175 "--compiler",	173 "--compiler",

176 "goma",	174 "goma",

177 "--goma-jsonstatus",	175 "--goma-jsonstatus",

178 "/path/to/tmp/json",	176 "/path/to/tmp/json",

179 "--goma-service-account-json-file",	177 "--goma-service-account-json-file",

180 "/creds/service_accounts/service-account-goma-client.json",	178 "/creds/service_accounts/service-account-goma-client.json",

181 "--goma-dir",	179 "--goma-dir",

182 "[BUILD]/goma",	180 "[BUILD]/goma",

183 "--",	181 "--",

184 "chromium_builder_tests"	182 "chromium_builder_tests"

(...skipping 15 matching lines...) Expand all Loading...
200 "[BUILD]/scripts/slave/chromium/nacl_sdk_buildbot_run.py"	198 "[BUILD]/scripts/slave/chromium/nacl_sdk_buildbot_run.py"

201 ],	199 ],

202 "name": "annotated_steps"	200 "name": "annotated_steps"

203 },	201 },

204 {	202 {

205 "name": "$result",	203 "name": "$result",

206 "recipe_result": null,	204 "recipe_result": null,

207 "status_code": 0	205 "status_code": 0

208 }	206 }

209 ]	207 ]

OLD	NEW