scripts/slave/recipes/dart/dartium_build.expected/basic_win_64_MirrorFalse.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/dart/dartium_build.expected/basic_win_64_MirrorFalse.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/dart/dartium_build.expected/basic_mac_64_MirrorTrue.json ('k') | scripts/slave/recipes/dart/dartium_build.expected/basic_win_64_MirrorTrue.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",	6 "RECIPE_PACKAGE_REPO[depot_tools]\\gclient.py",

7 "config",	7 "config",

8 "--spec",	8 "--spec",

9 "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': 'DEPS', 'managed': True, 'name': 'dartium.deps', 'url': 'https://dart.googlecode.com/svn/branches/b leeding_edge/deps/dartium.deps'}]"	9 "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': 'DEPS', 'managed': True, 'name': 'dartium.deps', 'url': 'https://dart.googlecode.com/svn/branches/b leeding_edge/deps/dartium.deps'}]"

10 ],	10 ],

(...skipping 87 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
98 "--gsutil-py-path",	98 "--gsutil-py-path",

99 "RECIPE_PACKAGE_REPO[depot_tools]\\gsutil.py",	99 "RECIPE_PACKAGE_REPO[depot_tools]\\gsutil.py",

100 "--ninja-path",	100 "--ninja-path",

101 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",	101 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",

102 "--target",	102 "--target",

103 "Release_x64",	103 "Release_x64",

104 "--src-dir",	104 "--src-dir",

105 "[SLAVE_BUILD]\\src",	105 "[SLAVE_BUILD]\\src",

106 "--goma-cache-dir",	106 "--goma-cache-dir",

107 "[GOMA_CACHE]",	107 "[GOMA_CACHE]",

108 "--build-tool",

109 "ninja",

110 "--compiler",	108 "--compiler",

111 "goma",	109 "goma",

112 "--goma-jsonstatus",	110 "--goma-jsonstatus",

113 "/path/to/tmp/json",	111 "/path/to/tmp/json",

114 "--goma-service-account-json-file",	112 "--goma-service-account-json-file",

115 "C:\\creds\\service_accounts\\service-account-goma-client.json",	113 "C:\\creds\\service_accounts\\service-account-goma-client.json",

116 "--goma-dir",	114 "--goma-dir",

117 "[BUILD]\\goma",	115 "[BUILD]\\goma",

118 "--",	116 "--",

119 "All",	117 "All",

(...skipping 16 matching lines...) Expand all Loading...
136 "12345"	134 "12345"

137 ],	135 ],

138 "name": "archive_build"	136 "name": "archive_build"

139 },	137 },

140 {	138 {

141 "name": "$result",	139 "name": "$result",

142 "recipe_result": null,	140 "recipe_result": null,

143 "status_code": 0	141 "status_code": 0

144 }	142 }

145 ]	143 ]

OLD	NEW