scripts/slave/recipes/closure_compilation.expected/closure_compilation_try.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/closure_compilation.expected/closure_compilation_try.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json ('k') | scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "tryserver.chromium.linux",	8 "tryserver.chromium.linux",

9 "--builder",	9 "--builder",

10 "closure_compilation",	10 "closure_compilation",

(...skipping 119 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
130 "--gsutil-py-path",	130 "--gsutil-py-path",

131 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	131 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

132 "--ninja-path",	132 "--ninja-path",

133 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	133 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

134 "--target",	134 "--target",

135 "Release",	135 "Release",

136 "--src-dir",	136 "--src-dir",

137 "[SLAVE_BUILD]/src",	137 "[SLAVE_BUILD]/src",

138 "--goma-cache-dir",	138 "--goma-cache-dir",

139 "[GOMA_CACHE]",	139 "[GOMA_CACHE]",

140 "--build-tool",

141 "ninja",

142 "--"	140 "--"

143 ],	141 ],

144 "env": {	142 "env": {

145 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"	143 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

146 },	144 },

147 "name": "compile"	145 "name": "compile"

148 },	146 },

149 {	147 {

150 "cmd": [	148 "cmd": [

151 "[SLAVE_BUILD]/src/build/gyp_chromium",	149 "[SLAVE_BUILD]/src/build/gyp_chromium",

(...skipping 12 matching lines...) Expand all Loading...
164 "--gsutil-py-path",	162 "--gsutil-py-path",

165 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	163 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

166 "--ninja-path",	164 "--ninja-path",

167 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	165 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

168 "--target",	166 "--target",

169 "Release",	167 "Release",

170 "--src-dir",	168 "--src-dir",

171 "[SLAVE_BUILD]/src",	169 "[SLAVE_BUILD]/src",

172 "--goma-cache-dir",	170 "--goma-cache-dir",

173 "[GOMA_CACHE]",	171 "[GOMA_CACHE]",

174 "--build-tool",

175 "ninja",

176 "--"	172 "--"

177 ],	173 ],

178 "env": {	174 "env": {

179 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"	175 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json"

180 },	176 },

181 "name": "compile_v2"	177 "name": "compile_v2"

182 },	178 },

183 {	179 {

184 "name": "$result",	180 "name": "$result",

185 "recipe_result": null,	181 "recipe_result": null,

186 "status_code": 0	182 "status_code": 0

187 }	183 }

188 ]	184 ]

OLD	NEW