scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_chromium_trybot.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json ('k') | scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot_test_failures.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "name": "taskkill"	8 "name": "taskkill"

9 },	9 },

10 {	10 {

(...skipping 405 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
416 "--ninja-path",	416 "--ninja-path",

417 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",	417 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",

418 "--target",	418 "--target",

419 "Release",	419 "Release",

420 "--src-dir",	420 "--src-dir",

421 "[BUILDER_CACHE]\\win_chromium_rel_ng\\src",	421 "[BUILDER_CACHE]\\win_chromium_rel_ng\\src",

422 "--goma-cache-dir",	422 "--goma-cache-dir",

423 "[GOMA_CACHE]",	423 "[GOMA_CACHE]",

424 "--goma-deps-cache-dir",	424 "--goma-deps-cache-dir",

425 "[GOMA_DEPS_CACHE]",	425 "[GOMA_DEPS_CACHE]",

426 "--build-tool",

427 "ninja",

428 "--compiler",	426 "--compiler",

429 "goma",	427 "goma",

430 "--goma-jsonstatus",	428 "--goma-jsonstatus",

431 "/path/to/tmp/json",	429 "/path/to/tmp/json",

432 "--goma-service-account-json-file",	430 "--goma-service-account-json-file",

433 "C:\\creds\\service_accounts\\service-account-goma-client.json",	431 "C:\\creds\\service_accounts\\service-account-goma-client.json",

434 "--goma-dir",	432 "--goma-dir",

435 "[CACHE]\\cipd\\goma",	433 "[CACHE]\\cipd\\goma",

436 "--goma-fail-fast",	434 "--goma-fail-fast",

437 "--goma-disable-local-fallback",	435 "--goma-disable-local-fallback",

(...skipping 151 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
589 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"	587 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"

590 },	588 },

591 "name": "process_dumps"	589 "name": "process_dumps"

592 },	590 },

593 {	591 {

594 "name": "$result",	592 "name": "$result",

595 "recipe_result": null,	593 "recipe_result": null,

596 "status_code": 0	594 "status_code": 0

597 }	595 }

598 ]	596 ]

OLD	NEW