scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/invalid_results.json ('k') | scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"	6 "RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\kill_processes.py"

7 ],	7 ],

8 "name": "taskkill"	8 "name": "taskkill"

9 },	9 },

10 {	10 {

(...skipping 369 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
380 "--ninja-path",	380 "--ninja-path",

381 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",	381 "RECIPE_PACKAGE_REPO[depot_tools]\\ninja.exe",

382 "--target",	382 "--target",

383 "Release",	383 "Release",

384 "--src-dir",	384 "--src-dir",

385 "[BUILDER_CACHE]\\win_layout\\src",	385 "[BUILDER_CACHE]\\win_layout\\src",

386 "--goma-cache-dir",	386 "--goma-cache-dir",

387 "[GOMA_CACHE]",	387 "[GOMA_CACHE]",

388 "--goma-deps-cache-dir",	388 "--goma-deps-cache-dir",

389 "[GOMA_DEPS_CACHE]",	389 "[GOMA_DEPS_CACHE]",

390 "--build-tool",

391 "ninja",

392 "--compiler",	390 "--compiler",

393 "goma",	391 "goma",

394 "--goma-jsonstatus",	392 "--goma-jsonstatus",

395 "/path/to/tmp/json",	393 "/path/to/tmp/json",

396 "--goma-service-account-json-file",	394 "--goma-service-account-json-file",

397 "C:\\creds\\service_accounts\\service-account-goma-client.json",	395 "C:\\creds\\service_accounts\\service-account-goma-client.json",

398 "--goma-dir",	396 "--goma-dir",

399 "[CACHE]\\cipd\\goma",	397 "[CACHE]\\cipd\\goma",

400 "--goma-fail-fast",	398 "--goma-fail-fast",

401 "--goma-disable-local-fallback",	399 "--goma-disable-local-fallback",

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
494 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"	492 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-ac count-goma-client.json"

495 },	493 },

496 "name": "process_dumps"	494 "name": "process_dumps"

497 },	495 },

498 {	496 {

499 "name": "$result",	497 "name": "$result",

500 "recipe_result": null,	498 "recipe_result": null,

501 "status_code": 0	499 "status_code": 0

502 }	500 }

503 ]	501 ]

OLD	NEW