scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/dynamic_instrumentation_cloud_test.json ('k') | scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.linux",	8 "chromium.linux",

9 "--builder",	9 "--builder",

10 "Android Builder",	10 "Android Builder",

(...skipping 301 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
312 "--gsutil-py-path",	312 "--gsutil-py-path",

313 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	313 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

314 "--ninja-path",	314 "--ninja-path",

315 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	315 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

316 "--target",	316 "--target",

317 "Release",	317 "Release",

318 "--src-dir",	318 "--src-dir",

319 "[SLAVE_BUILD]/src",	319 "[SLAVE_BUILD]/src",

320 "--goma-cache-dir",	320 "--goma-cache-dir",

321 "[GOMA_CACHE]",	321 "[GOMA_CACHE]",

322 "--build-tool",

323 "ninja",

324 "--compiler",	322 "--compiler",

325 "goma",	323 "goma",

326 "--goma-jsonstatus",	324 "--goma-jsonstatus",

327 "/path/to/tmp/json",	325 "/path/to/tmp/json",

328 "--goma-service-account-json-file",	326 "--goma-service-account-json-file",

329 "/creds/service_accounts/service-account-goma-client.json",	327 "/creds/service_accounts/service-account-goma-client.json",

330 "--goma-dir",	328 "--goma-dir",

331 "[CACHE]/cipd/goma",	329 "[CACHE]/cipd/goma",

332 "--",	330 "--",

333 "blimp_test_apk"	331 "blimp_test_apk"

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
397 "~followup_annotations": [	395 "~followup_annotations": [

398 "@@@STEP_TEXT@Android Tests@@@"	396 "@@@STEP_TEXT@Android Tests@@@"

399 ]	397 ]

400 },	398 },

401 {	399 {

402 "name": "$result",	400 "name": "$result",

403 "recipe_result": null,	401 "recipe_result": null,

404 "status_code": 0	402 "status_code": 0

405 }	403 }

406 ]	404 ]

OLD	NEW