scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json ('k') | scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "chromium.webkit",	8 "chromium.webkit",

9 "--builder",	9 "--builder",

10 "WebKit Linux",	10 "WebKit Linux",

(...skipping 255 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
266 "--gsutil-py-path",	266 "--gsutil-py-path",

267 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	267 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

268 "--ninja-path",	268 "--ninja-path",

269 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	269 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

270 "--target",	270 "--target",

271 "Release",	271 "Release",

272 "--src-dir",	272 "--src-dir",

273 "[SLAVE_BUILD]/src",	273 "[SLAVE_BUILD]/src",

274 "--goma-cache-dir",	274 "--goma-cache-dir",

275 "[GOMA_CACHE]",	275 "[GOMA_CACHE]",

276 "--build-tool",

277 "ninja",

278 "--compiler",	276 "--compiler",

279 "goma",	277 "goma",

280 "--goma-jsonstatus",	278 "--goma-jsonstatus",

281 "/path/to/tmp/json",	279 "/path/to/tmp/json",

282 "--goma-service-account-json-file",	280 "--goma-service-account-json-file",

283 "/creds/service_accounts/service-account-goma-client.json",	281 "/creds/service_accounts/service-account-goma-client.json",

284 "--goma-dir",	282 "--goma-dir",

285 "[CACHE]/cipd/goma",	283 "[CACHE]/cipd/goma",

286 "--ninja-ensure-up-to-date",	284 "--ninja-ensure-up-to-date",

287 "--",	285 "--",

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
368 "@@@STEP_LINK@(zip)@https://storage.googleapis.com/chromium-layout-test-ar chives/WebKit_Linux/571/layout-test-results.zip@@@"	366 "@@@STEP_LINK@(zip)@https://storage.googleapis.com/chromium-layout-test-ar chives/WebKit_Linux/571/layout-test-results.zip@@@"

369 ]	367 ]

370 },	368 },

371 {	369 {

372 "name": "$result",	370 "name": "$result",

373 "reason": "1 tests failed: ['webkit_tests']",	371 "reason": "1 tests failed: ['webkit_tests']",

374 "recipe_result": null,	372 "recipe_result": null,

375 "status_code": 1	373 "status_code": 1

376 }	374 }

377 ]	375 ]

OLD	NEW