scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json - Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json

Issue 2152453003: recipes: Stop passing --build-tool=ninja to compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json ('k') | scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "python",	4 "python",

5 "-u",	5 "-u",

6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",	6 "RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

7 "--master",	7 "--master",

8 "client.v8.fyi",	8 "client.v8.fyi",

9 "--builder",	9 "--builder",

10 "V8-Blink Linux 64",	10 "V8-Blink Linux 64",

(...skipping 144 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
155 "--gsutil-py-path",	155 "--gsutil-py-path",

156 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",	156 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",

157 "--ninja-path",	157 "--ninja-path",

158 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",	158 "RECIPE_PACKAGE_REPO[depot_tools]/ninja",

159 "--target",	159 "--target",

160 "Release",	160 "Release",

161 "--src-dir",	161 "--src-dir",

162 "[SLAVE_BUILD]/src",	162 "[SLAVE_BUILD]/src",

163 "--goma-cache-dir",	163 "--goma-cache-dir",

164 "[GOMA_CACHE]",	164 "[GOMA_CACHE]",

165 "--build-tool",

166 "ninja",

167 "--compiler",	165 "--compiler",

168 "goma",	166 "goma",

169 "--goma-jsonstatus",	167 "--goma-jsonstatus",

170 "/path/to/tmp/json",	168 "/path/to/tmp/json",

171 "--goma-service-account-json-file",	169 "--goma-service-account-json-file",

172 "/creds/service_accounts/service-account-goma-client.json",	170 "/creds/service_accounts/service-account-goma-client.json",

173 "--goma-dir",	171 "--goma-dir",

174 "[BUILD]/goma",	172 "[BUILD]/goma",

175 "--",	173 "--",

176 "blink_tests"	174 "blink_tests"

(...skipping 109 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
286 "@@@STEP_FAILURE@@@"	284 "@@@STEP_FAILURE@@@"

287 ]	285 ]

288 },	286 },

289 {	287 {

290 "name": "$result",	288 "name": "$result",

291 "reason": "1 out of 1 aggregated steps failed. Failures: Step('webkit_tests' ) failed with return_code 1",	289 "reason": "1 out of 1 aggregated steps failed. Failures: Step('webkit_tests' ) failed with return_code 1",

292 "recipe_result": null,	290 "recipe_result": null,

293 "status_code": 1	291 "status_code": 1

294 }	292 }

295 ]	293 ]

OLD	NEW