Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/gn/ninja_toolchain_writer_unittest.cc

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_toolchain_writer.cc ('k') | tools/gn/ninja_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_toolchain_writer_unittest.cc
diff --git a/tools/gn/ninja_toolchain_writer_unittest.cc b/tools/gn/ninja_toolchain_writer_unittest.cc
index fc52f7da7be7df56513bc6f13b0e3a7991ca42d3..4e9d7674957d45525ac70dcbb69b1963a94bcba5 100644
--- a/tools/gn/ninja_toolchain_writer_unittest.cc
+++ b/tools/gn/ninja_toolchain_writer_unittest.cc
@@ -11,14 +11,8 @@
TEST(NinjaToolchainWriter, WriteToolRule) {
TestWithScope setup;
- //Target target(setup.settings(), Label(SourceDir("//foo/"), "target"));
- //target.set_output_type(Target::EXECUTABLE);
- //target.SetToolchain(setup.toolchain());
-
std::ostringstream stream;
-
- NinjaToolchainWriter writer(setup.settings(), setup.toolchain(),
- std::vector<const Target*>(), stream);
+ NinjaToolchainWriter writer(setup.settings(), setup.toolchain(), stream);
writer.WriteToolRule(Toolchain::TYPE_CC,
setup.toolchain()->GetTool(Toolchain::TYPE_CC),
std::string("prefix_"));
« no previous file with comments | « tools/gn/ninja_toolchain_writer.cc ('k') | tools/gn/ninja_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698