Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: tools/gn/ninja_target_writer.h

Issue 2152413002: GN: don't write separate files for non-binary targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: win_test_fixes Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_build_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.h
diff --git a/tools/gn/ninja_target_writer.h b/tools/gn/ninja_target_writer.h
index 0248b0788d765a07deb390f986527fffd4db5a6d..fd781ead19413a547eec23293ba5286bcbb8d064 100644
--- a/tools/gn/ninja_target_writer.h
+++ b/tools/gn/ninja_target_writer.h
@@ -24,7 +24,14 @@ class NinjaTargetWriter {
NinjaTargetWriter(const Target* target, std::ostream& out);
virtual ~NinjaTargetWriter();
- static void RunAndWriteFile(const Target* target);
+ // Returns the build line to be written to the toolchain build file.
+ //
+ // Some targets have their rules get written to separate files, and some
brucedawson 2016/07/25 17:38:00 "rules get written" -> "rules written"
+ // can have their rules coalesced in the main build file. For the coalesced
+ // case, this function will return the rules as a string. For the separate
+ // file case, the separate ninja file will be written and the return string
+ // will be the subninja command to load that file.
+ static std::string RunAndWriteFile(const Target* target);
virtual void Run() = 0;
« no previous file with comments | « tools/gn/ninja_build_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698