GN: don't write separate files for non-binary targets

tools/gn/json_project_writer.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/json_project_writer.h"
 
 #include <iostream>
 
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
@@ skipping 64 matching lines @@
   // in the generated project (and thus stability of the file generated).
   std::sort(targets->begin(), targets->end(),
             [](const Target* a, const Target* b) {
               return a->label().name() < b->label().name();
             });
 
   return true;
 }
 
 std::string RenderJSON(const BuildSettings* build_settings,
-                       const Builder* builder,
+                       const Builder& builder,
                        std::vector<const Target*>& all_targets) {
   Label default_toolchain_label;
 
   auto targets = base::WrapUnique(new base::DictionaryValue());
   for (const auto* target : all_targets) {
     if (default_toolchain_label.is_null())
       default_toolchain_label = target->settings()->default_toolchain_label();
     auto description =
         DescBuilder::DescriptionForTarget(target, "", false, false, false);
     // Outputs need to be asked for separately.
@@ skipping 64 matching lines @@
     return false;
   }
 
   return true;
 }
 
 }  // namespace
 
 bool JSONProjectWriter::RunAndWriteFiles(
     const BuildSettings* build_settings,
-    const Builder* builder,
+    const Builder& builder,
     const std::string& file_name,
     const std::string& exec_script,
     const std::string& exec_script_extra_args,
     const std::string& dir_filter_string,
     bool quiet,
     Err* err) {
   SourceFile output_file = build_settings->build_dir().ResolveRelativeFile(
       Value(nullptr, file_name), err);
   if (output_file.is_null()) {
     return false;
   }
 
   base::FilePath output_path = build_settings->GetFullPath(output_file);
 
-  std::vector<const Target*> all_targets = builder->GetAllResolvedTargets();
+  std::vector<const Target*> all_targets = builder.GetAllResolvedTargets();
   std::vector<const Target*> targets;
   if (!FilterTargets(build_settings, all_targets, &targets, dir_filter_string,
                      err)) {
     return false;
   }
 
   std::string json = RenderJSON(build_settings, builder, targets);
   if (!ContentsEqual(output_path, json)) {
     if (!WriteFileIfChanged(output_path, json, err)) {
       return false;
@@ skipping 12 matching lines @@
         script_file = SourceFile(exec_script);
       }
       base::FilePath script_path = build_settings->GetFullPath(script_file);
       return InvokePython(build_settings, script_path, exec_script_extra_args,
                           output_path, quiet, err);
     }
   }
 
   return true;
 }