GN: don't write separate files for non-binary targets

tools/gn/builder.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_GN_BUILDER_H_
 #define TOOLS_GN_BUILDER_H_
 
 #include "base/callback.h"
 #include "base/containers/hash_tables.h"
 #include "base/macros.h"
-#include "base/memory/ref_counted.h"
 #include "tools/gn/builder_record.h"
 #include "tools/gn/label.h"
 #include "tools/gn/label_ptr.h"
 #include "tools/gn/unique_vector.h"
 
 class Config;
 class Err;
 class Loader;
 class ParseNode;
 
-class Builder : public base::RefCountedThreadSafe<Builder> {
+// The builder assembles the dependency tree. It is not threadsafe and runs on
+// the main thread only. See also BuilderRecord.
+class Builder {
  public:
   typedef base::Callback<void(const BuilderRecord*)> ResolvedCallback;
 
   explicit Builder(Loader* loader);
+  ~Builder();
 
   // The resolved callback is called whenever a target has been resolved. This
   // will be executed only on the main thread.
   void set_resolved_callback(const ResolvedCallback& cb) {
     resolved_callback_ = cb;
   }
 
   Loader* loader() const { return loader_; }
 
   void ItemDefined(std::unique_ptr<Item> item);
 
   // Returns NULL if there is not a thing with the corresponding label.
   const Item* GetItem(const Label& label) const;
   const Toolchain* GetToolchain(const Label& label) const;
 
   std::vector<const BuilderRecord*> GetAllRecords() const;
 
   // Returns targets which should be generated and which are defined.
   std::vector<const Target*> GetAllResolvedTargets() const;
 
   // Returns the record for the given label, or NULL if it doesn't exist.
   // Mostly used for unit tests.
   const BuilderRecord* GetRecord(const Label& label) const;
   BuilderRecord* GetRecord(const Label& label);
 
   // If there are any undefined references, returns false and sets the error.
   bool CheckForBadItems(Err* err) const;
 
  private:
-  friend class base::RefCountedThreadSafe<Builder>;
-
-  virtual ~Builder();
-
   bool TargetDefined(BuilderRecord* record, Err* err);
   bool ConfigDefined(BuilderRecord* record, Err* err);
   bool ToolchainDefined(BuilderRecord* record, Err* err);
 
   // Returns the record associated with the given label. This function checks
   // that if we already have references for it, the type matches. If no record
   // exists yet, a new one will be created.
   //
   // If any of the conditions fail, the return value will be null and the error
   // will be set. request_from is used as the source of the error.
@@ skipping 63 matching lines @@
   // Owning pointers.
   typedef base::hash_map<Label, BuilderRecord*> RecordMap;
   RecordMap records_;
 
   ResolvedCallback resolved_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(Builder);
 };
 
 #endif  // TOOLS_GN_BUILDER_H_