GN: don't write separate files for non-binary targets

tools/gn/visual_studio_writer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/visual_studio_writer.h"
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 #include <memory>
@@ skipping 148 matching lines @@
 base::StringPiece FindParentDir(const std::string* path) {
   DCHECK(path && !path->empty());
   for (int i = static_cast<int>(path->size()) - 2; i >= 0; --i) {
     if (IsSlash((*path)[i]))
       return base::StringPiece(path->data(), i);
   }
   return base::StringPiece();
 }
 
 bool FilterTargets(const BuildSettings* build_settings,
-                   Builder* builder,
+                   const Builder& builder,
                    const std::string& dir_filters,
                    std::vector<const Target*>* targets,
                    Err* err) {
   if (dir_filters.empty()) {
-    *targets = builder->GetAllResolvedTargets();
+    *targets = builder.GetAllResolvedTargets();
     return true;
   }
 
   std::vector<LabelPattern> filters;
   if (!commands::FilterPatternsFromString(build_settings, dir_filters, &filters,
                                           err))
     return false;
 
-  commands::FilterTargetsByPatterns(builder->GetAllResolvedTargets(), filters,
+  commands::FilterTargetsByPatterns(builder.GetAllResolvedTargets(), filters,
                                     targets);
 
   std::set<Label> labels;
   std::queue<const Target*> to_process;
   for (const Target* target : *targets) {
     labels.insert(target->label());
     to_process.push(target);
   }
 
   while (!to_process.empty()) {
@@ skipping 68 matching lines @@
   }
 
   windows_kits_include_dirs_ = GetWindowsKitsIncludeDirs();
 }
 
 VisualStudioWriter::~VisualStudioWriter() {
 }
 
 // static
 bool VisualStudioWriter::RunAndWriteFiles(const BuildSettings* build_settings,
-                                          Builder* builder,
+                                          const Builder& builder,
                                           Version version,
                                           const std::string& sln_name,
                                           const std::string& dir_filters,
                                           Err* err) {
   std::vector<const Target*> targets;
   if (!FilterTargets(build_settings, builder, dir_filters, &targets, err))
     return false;
 
   const char* config_platform = "Win32";
 
@@ skipping 549 matching lines @@
   }
 }
 
 std::string VisualStudioWriter::GetNinjaTarget(const Target* target) {
   std::ostringstream ninja_target_out;
   DCHECK(!target->dependency_output_file().value().empty());
   ninja_path_output_.WriteFile(ninja_target_out,
                                target->dependency_output_file());
   return ninja_target_out.str();
 }