Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 2152373003: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_test.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc
index 1bc1eac1ae248a56c861da8de03788acb98ff51c..fc2524b3e9d248976ddaac7385ecfb22925dffa2 100644
--- a/chrome/browser/extensions/api/tabs/tabs_test.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_test.cc
@@ -153,7 +153,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, MAYBE_GetWindow) {
EXPECT_EQ(window_id, GetWindowId(result.get()));
// "populate" was enabled so tabs should be populated.
base::ListValue* tabs = nullptr;
- EXPECT_TRUE(result.get()->GetList(keys::kTabsKey, &tabs));
+ EXPECT_TRUE(result->GetList(keys::kTabsKey, &tabs));
base::Value* tab0 = nullptr;
EXPECT_TRUE(tabs->Get(0, &tab0));
@@ -240,7 +240,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, GetCurrentWindow) {
// to RunFunctionAndReturnSingleResult.
EXPECT_EQ(new_id, GetWindowId(result.get()));
base::ListValue* tabs = nullptr;
- EXPECT_FALSE(result.get()->GetList(keys::kTabsKey, &tabs));
+ EXPECT_FALSE(result->GetList(keys::kTabsKey, &tabs));
// Get the current window using the old window and make the tabs populated.
function = new WindowsGetCurrentFunction();
@@ -254,7 +254,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, GetCurrentWindow) {
// to RunFunctionAndReturnSingleResult.
EXPECT_EQ(window_id, GetWindowId(result.get()));
// "populate" was enabled so tabs should be populated.
- EXPECT_TRUE(result.get()->GetList(keys::kTabsKey, &tabs));
+ EXPECT_TRUE(result->GetList(keys::kTabsKey, &tabs));
// The tab id should not be -1 as this is a browser window.
base::Value* tab0 = nullptr;

Powered by Google App Engine
This is Rietveld 408576698